Fix: array @type parsing - iterate over $type not $types#8
Open
omiba wants to merge 1 commit intobrick:masterfrom
Open
Fix: array @type parsing - iterate over $type not $types#8omiba wants to merge 1 commit intobrick:masterfrom
omiba wants to merge 1 commit intobrick:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@typevalues (e.g.,["Recipe", "NewsArticle"]) were not being parsed$types(empty array) was used instead of$type(the actual array)Problem
When parsing JSON-LD with array-style
@typelike:{ "@context": "http://schema.org", "@type": ["Recipe", "NewsArticle"], "name": "Good Old-Fashioned Pancakes" }The library would return an item with no types because line 154 iterated over
$types(an empty array initialized on line 143) instead of$type(the array from the JSON).This affects major recipe sites like AllRecipes.com which use array-style
@typevalues.Fix
Changed line 154 from:
$types,to:
$type,Also renamed the closure parameter from
$typeto$tto avoid shadowing the outer$typevariable.Test plan
@typevalues are now properly resolved🤖 Generated with Claude Code